Auto-port 5.0: Fix ResumptionController wrapping#16818
Merged
Merged
Conversation
Motivation: ReferenceCountedOpenSslContext did not propagate the wrapped trust manager from the resumption controller. With poorly implemented ResumableX509ExtendedTrustManager instances, this can waste a few resources by re-validating initial handshakes as if they are _also_ a resumed session. Modification: Change the ReferenceCountedOpenSslContext to ensure that the result of ResumptionController.wrapIfNeeded is passed through to later wrapping steps, if any. Result: No more unnecessary double-validation for resumable trust managers. (cherry picked from commit c328ba2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-port of #16815 to 5.0
Cherry-picked commit: c328ba2
Motivation:
ReferenceCountedOpenSslContext did not propagate the wrapped trust manager from the resumption controller. With poorly implemented ResumableX509ExtendedTrustManager instances, this can waste a few resources by re-validating initial handshakes as if they are also a resumed session.
Modification:
Change the ReferenceCountedOpenSslContext to ensure that the result of ResumptionController.wrapIfNeeded is passed through to later wrapping steps, if any.
Result:
No more unnecessary double-validation for resumable trust managers.