Auto-port 4.1: H2: Add test for header value validation#16741
Closed
netty-project-bot wants to merge 2 commits into
Closed
Auto-port 4.1: H2: Add test for header value validation#16741netty-project-bot wants to merge 2 commits into
netty-project-bot wants to merge 2 commits into
Conversation
Motivation: We have header value validation for DefaultHttp2Headers, including pseudo headers, though it is opt-in and needs to be enabled explicitly. However, we don't have an HTTP/2 test that shows it working. Modification: Add a test to DefaultHttp2HeadersTest that shows how value validation rejects headers with illegal token characters. Result: We have a test that proves H2 header value validation works. (cherry picked from commit a50db19)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-port of #16737 to 4.1
Cherry-picked commit: a50db19
Motivation:
We have header value validation for DefaultHttp2Headers, including pseudo headers, though it is opt-in and needs to be enabled explicitly.
However, we don't have an HTTP/2 test that shows it working.
Modification:
Add a test to DefaultHttp2HeadersTest that shows how value validation rejects headers with illegal token characters.
Result:
We have a test that proves H2 header value validation works.