Consolidate fake exceptions in HTTP/2 tests into Http2TestUtil#16712
Merged
normanmaurer merged 1 commit intoApr 29, 2026
Conversation
normanmaurer
approved these changes
Apr 28, 2026
normanmaurer
added
needs-cherry-pick-4.1
Contributor
|
Auto-port PR for 4.1: #16725 |
github-actions
Bot
removed
the
needs-cherry-pick-4.1
Contributor
|
Could not create auto-port PR. |
Member
|
Port for 5.0 #16726 |
normanmaurer
added a commit
that referenced
this pull request
Apr 29, 2026
… (#16726) Motivation: HTTP/2 tests create ad-hoc fake exceptions to drive error paths. Modification: Add `Http2TestUtil.FAKE_EXCEPTION` (stackless singleton) and replace local instances across 8 test classes. Result: Fixes #4274 Co-authored-by: fru1tworld <[email protected]>
normanmaurer
pushed a commit
that referenced
this pull request
Apr 29, 2026
…TestUtil (#16725) Auto-port of #16712 to 4.1 Cherry-picked commit: 27b6a1b --- Motivation: HTTP/2 tests create ad-hoc fake exceptions to drive error paths. Modification: Add `Http2TestUtil.FAKE_EXCEPTION` (stackless singleton) and replace local instances across 8 test classes. Result: Fixes #4274 Co-authored-by: fru1tworld <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
HTTP/2 tests create ad-hoc fake exceptions to drive error paths.
Modification:
Add
Http2TestUtil.FAKE_EXCEPTION(stackless singleton) and replace local instances across 8 test classes.Result:
Fixes #4274