IoUring: Fix incorrect assertion which was triggered when two Channel…#16705
Merged
Conversation
Member
Author
|
/cc @dreamlike-ocean |
Member
Author
|
/cc @vietj @tsegismont |
normanmaurer
force-pushed
the
gathering_same_eventloop
branch
2 times, most recently
from
89513c7 to
75264ae
Compare
…s on the same EventLoop did a gathering write Motivation: The assertion was in the incorrect place and so was incorrectly triggered when a gathering write was done on two Channel on the same EventLoop without submitting inbetween. Modification: - Move assert in the correct place - Add unit test Result: No more assertion failure
normanmaurer
force-pushed
the
gathering_same_eventloop
branch
from
75264ae to
26d9b2f
Compare
Contributor
|
Thank you @normanmaurer ! |
chrisvest
approved these changes
Apr 24, 2026
15 tasks
chrisvest
added
the
needs-cherry-pick-5.0
Contributor
|
Could not create auto-port PR. |
chrisvest
removed
the
needs-cherry-pick-5.0
Member
|
Does this need to be ported to 5.0? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…s on the same EventLoop did a gathering write
Motivation:
The assertion was in the incorrect place and so was incorrectly triggered when a gathering write was done on two Channel on the same EventLoop without submitting inbetween.
Modification:
Result:
No more assertion failure