Auto-port 4.1: Avoid TCPFastOpen in KQueueCompositeBufferGatheringWriteTest#16699
Merged
Conversation
Motivation: We have seen occasional failures from this test in CI, like: ``` Error: io.netty.channel.kqueue.KQueueCompositeBufferGatheringWriteTest.testSingleCompositeBufferWrite(TestInfo) -- Time elapsed: 0.045 s <<< FAILURE! org.opentest4j.AssertionFailedError: expected: <20> but was: <0> at io.netty.testsuite.transport.socket.CompositeBufferGatheringWriteTest$3$1.channelInactive(CompositeBufferGatheringWriteTest.java:109) ``` In the test, the server writes a composite buffer with 20 bytes as soon as a client connects, and the write future has a listener that closes the channel. I speculate that maybe the close races ahead of the write, when TFO is enabled. Normally, the kernel should still drain the send buffer of closed sockets, but maybe there's an interaction with TFO there. Modification: Disable the use of TFO in KQueueCompositeBufferGatheringWriteTest, which matches its epoll counterpart. Log warnings if an unusual IOException gets thrown on the client. Result: Maybe more stable test. (cherry picked from commit 38f7a73)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-port of #16697 to 4.1
Cherry-picked commit: 38f7a73
Motivation:
We have seen occasional failures from this test in CI, like:
In the test, the server writes a composite buffer with 20 bytes as soon as a client connects, and the write future has a listener that closes the channel. I speculate that maybe the close races ahead of the write, when TFO is enabled. Normally, the kernel should still drain the send buffer of closed sockets, but maybe there's an interaction with TFO there.
Modification:
Disable the use of TFO in KQueueCompositeBufferGatheringWriteTest, which matches its epoll counterpart. Log warnings if an unusual IOException gets thrown on the client.
Result:
Maybe more stable test.