Auto-port 5.0: Propagate exceptions from inner threads in buffer tests#16653
Merged
Conversation
Motivation: If there are assertion failures inside threads started by a test, we need to ensure that the exception propagates out of the test, instead of just killing the started thread. This is likely the cause of some test timeouts we're seeing, and this change will help us uncover the root causes. Modification: Catch exceptions inside threads started by the tests, and make sure to progress relevant barriers. Propagate the exception to the test-running thread so we capture the cause. Result: Easier to debug tests. (cherry picked from commit 4f3533a)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-port of #16643 to 5.0
Cherry-picked commit: 4f3533a
Motivation:
If there are assertion failures inside threads started by a test, we need to ensure that the exception propagates out of the test, instead of just killing the started thread. This is likely the cause of some test timeouts we're seeing, and this change will help us uncover the root causes.
Modification:
Catch exceptions inside threads started by the tests, and make sure to progress relevant barriers. Propagate the exception to the test-running thread so we capture the cause.
Result:
Easier to debug tests.