Auto-port 4.1: Stabilize testSessionInvalidate for Conscrypt#16616
Merged
Conversation
Motivation: For TLSv1.3 I think Conscrypt only adds sessions to its cache once the NewSessionTicket has been issued, and attempts to invalidate the session before this point has no effect, which made the test flaky. Modification: Add rounds of packet transfers to the test to ensure that TLSv1.3 always issues NewSessionTicket messages prior to the invalidation of the session. Result: More stable build. (cherry picked from commit b2662ca)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-port of #16615 to 4.1
Cherry-picked commit: b2662ca
Motivation:
For TLSv1.3 I think Conscrypt only adds sessions to its cache once the NewSessionTicket has been issued, and attempts to invalidate the session before this point has no effect, which made the test flaky.
Modification:
Add rounds of packet transfers to the test to ensure that TLSv1.3 always issues NewSessionTicket messages prior to the invalidation of the session.
Result:
More stable build.