Auto-port 4.1: Stabilize more AbstractByteBufTests#16613
Merged
Conversation
Motivation: We have a mix of different timeout approaches going on. We should settle on 30+ seconds minimum, because on busy CI runners it can take seconds to start new threads. Modification: Make some test barrier awaits unbounded and instead rely on `@Timeout` annotations on the tests. Increase the timeouts to 30 seconds, from 10. Result: More stable build. (cherry picked from commit 5f019e7)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-port of #16611 to 4.1
Cherry-picked commit: 5f019e7
Motivation:
We have a mix of different timeout approaches going on. We should settle on 30+ seconds minimum, because on busy CI runners it can take seconds to start new threads.
Modification:
Make some test barrier awaits unbounded and instead rely on
@Timeoutannotations on the tests. Increase the timeouts to 30 seconds, from 10.Result:
More stable build.