Auto-port 5.0: Stabilize read-only toStringMultipleThreads1#16609
Merged
Conversation
Motivation: In #16380 we increased the timeout of this test. However, `ReadOnlyDirectByteBufTest` does not inherit from AbstractBtyeBufTest and instead has its own version. We did not increase the timeout of this version. Modification: Increase the timeout of the read-only ByteBuf version of the test, to match what we use for all other buffer types. Result: More stable build. (cherry picked from commit 8984978)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-port of #16608 to 5.0
Cherry-picked commit: 8984978
Motivation:
In #16380 we increased the timeout of this test. However,
ReadOnlyDirectByteBufTestdoes not inherit from AbstractBtyeBufTest and instead has its own version. We did not increase the timeout of this version.Modification:
Increase the timeout of the read-only ByteBuf version of the test, to match what we use for all other buffer types.
Result:
More stable build.