AdaptivePoolingAllocator: remove ensureAccessible() call in capacity(int) method#16473
Merged
Merged
Conversation
normanmaurer
added
needs-cherry-pick-4.1
netty-project-bot
pushed a commit
that referenced
this pull request
Mar 16, 2026
…ty(int)` method (#16473) Motivation: In `AdaptivePoolingAllocator.capacity(int)`, the call to `checkNewCapacity(newCapacity)` already invokes `ensureAccessible()` internally, making the explicit `ensureAccessible()` call redundant. Modification: Remove the redundant `ensureAccessible()` call from the `capacity(int)` method. Result: Reducing unnecessary overhead. (cherry picked from commit 2ac5bf4)
Contributor
|
Auto-port PR for 4.1: #16475 |
netty-project-bot
pushed a commit
that referenced
this pull request
Mar 16, 2026
…ty(int)` method (#16473) Motivation: In `AdaptivePoolingAllocator.capacity(int)`, the call to `checkNewCapacity(newCapacity)` already invokes `ensureAccessible()` internally, making the explicit `ensureAccessible()` call redundant. Modification: Remove the redundant `ensureAccessible()` call from the `capacity(int)` method. Result: Reducing unnecessary overhead. (cherry picked from commit 2ac5bf4)
Contributor
|
Auto-port PR for 5.0: #16476 |
github-actions
Bot
removed
the
needs-cherry-pick-4.1
github-actions
Bot
removed
the
needs-cherry-pick-5.0
normanmaurer
pushed a commit
that referenced
this pull request
Mar 16, 2026
…call in `capacity(int)` method (#16475) Auto-port of #16473 to 4.1 Cherry-picked commit: 2ac5bf4 --- Motivation: In `AdaptivePoolingAllocator.capacity(int)`, the call to `checkNewCapacity(newCapacity)` already invokes `ensureAccessible()` internally, making the explicit `ensureAccessible()` call redundant. Modification: Remove the redundant `ensureAccessible()` call from the `capacity(int)` method. Result: Reducing unnecessary overhead. Co-authored-by: old driver <[email protected]>
normanmaurer
pushed a commit
that referenced
this pull request
Mar 16, 2026
…call in `capacity(int)` method (#16476) Auto-port of #16473 to 5.0 Cherry-picked commit: 2ac5bf4 --- Motivation: In `AdaptivePoolingAllocator.capacity(int)`, the call to `checkNewCapacity(newCapacity)` already invokes `ensureAccessible()` internally, making the explicit `ensureAccessible()` call redundant. Modification: Remove the redundant `ensureAccessible()` call from the `capacity(int)` method. Result: Reducing unnecessary overhead. Co-authored-by: old driver <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
In
AdaptivePoolingAllocator.capacity(int), the call tocheckNewCapacity(newCapacity)already invokesensureAccessible()internally, making the explicitensureAccessible()call redundant.Modification:
Remove the redundant
ensureAccessible()call from thecapacity(int)method.Result:
Reducing unnecessary overhead.