Fire the QuicChannel datagram extension event before the channel becomes active#16425
Merged
normanmaurer merged 1 commit intoMar 10, 2026
Conversation
…mes active. Motivation: The QuicheQuicChannel implementation fires the datagram extension event after the channel becomes active. In addition this event is optional, implying there is no trival way to determine than the extension is available when the channel becomes active and is supposed to be functionnal at this moment. Modification: Fire the datagram extension event before the channel becomes active. Result: When the QuicChannel becomes active, handlers are fully aware whether the channel extension is available and will have the knowledge of the max datagram len.
normanmaurer
added
the
needs-cherry-pick-5.0
Contributor
|
Could not create auto-port PR. |
normanmaurer
pushed a commit
that referenced
this pull request
Mar 10, 2026
…mes active (#16425) Motivation: The `QuicheQuicChannel` implementation fires the datagram extension event after the channel becomes active. In addition this event is optional, implying there is no trival way to determine than the extension is available when the channel becomes active and is supposed to be functionnal at this moment. Modification: Fire the datagram extension event before the channel becomes active. Result: When the `QuicChannel` becomes active, handlers are fully aware whether the channel extension is available and will have the knowledge of the max datagram len.
Member
|
Opened #16431 |
normanmaurer
added a commit
that referenced
this pull request
Mar 11, 2026
…mes active (#16425) (#16431) Motivation: The `QuicheQuicChannel` implementation fires the datagram extension event after the channel becomes active. In addition this event is optional, implying there is no trival way to determine than the extension is available when the channel becomes active and is supposed to be functionnal at this moment. Modification: Fire the datagram extension event before the channel becomes active. Result: When the `QuicChannel` becomes active, handlers are fully aware whether the channel extension is available and will have the knowledge of the max datagram len. --------- Co-authored-by: Julien Viet <[email protected]>
chrisvest
removed
the
needs-cherry-pick-5.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
The
QuicheQuicChannelimplementation fires the datagram extension event after the channel becomes active.In addition this event is optional, implying there is no trival way to determine than the extension is available when the channel becomes active and is supposed to be functionnal at this moment.
Modification:
Fire the datagram extension event before the channel becomes active.
Result:
When the
QuicChannelbecomes active, handlers are fully aware whether the channel extension is available and will have the knowledge of the max datagram len.