Local transport: shutdown hook should call closeNow to be conistent with what LocalIoHandler will call#16406
Merged
Merged
Conversation
…ith what LocalIoHandler will call Motivation: When LocalIoHandler is used it will call closeNow() to handle the close of the Local*Channel when destroyed. We should use the the same method when using a shutdown hook to do the same to make things consistent. Modifications: - Move shutdownHook to inner class as it is where it is used. - call closeNow to make it conistent Result: Cleanup
normanmaurer
added
the
needs-cherry-pick-5.0
Contributor
|
Could not create auto-port PR. |
chrisvest
removed
the
needs-cherry-pick-5.0
Member
|
I think the shutdown hook concept was removed in 5.0, so no cherry-pick needed. |
Member
Author
|
@chrisvest yes... forgot to remove the label.. thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
When LocalIoHandler is used it will call closeNow() to handle the close of the Local*Channel when destroyed. We should use the the same method when using a shutdown hook to do the same to make things consistent.
Modifications:
Result:
Cleanup