Auto-port 5.0: IoUring: Reduce unnecessary io_uring_enter syscalls on non-blocking path#16397
Merged
Conversation
…ath (#16259) Motivation: In `IoUringIoHandler.run()`, the non-blocking path unconditionally calls `io_uring_enter` via `submitAndClearNow()` even when there are no pending SQEs and no deferred task work to flush. Modification: - Enable `IORING_SETUP_TASKRUN_FLAG` when `IORING_SETUP_DEFER_TASKRUN` is set, so the kernel signals `IORING_SQ_TASKRUN` when deferred completions are pending. Result: Fixes #16247. No regression under high concurrency load. Under IO-idle non-blocking path scenario, `io_uring_enter` calls reduced from 486 to 65 (-86.6%). --------- Co-authored-by: Norman Maurer <[email protected]> (cherry picked from commit bedd0ac)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-port of #16259 to 5.0
Cherry-picked commit: bedd0ac
Motivation:
In
IoUringIoHandler.run(), the non-blocking path unconditionally callsio_uring_enterviasubmitAndClearNow()even when there are no pending SQEs and no deferred task work to flush.Modification:
IORING_SETUP_TASKRUN_FLAGwhenIORING_SETUP_DEFER_TASKRUNis set,so the kernel signals
IORING_SQ_TASKRUNwhen deferred completions are pending.Result:
Fixes #16247.
No regression under high concurrency load. Under IO-idle non-blocking
path scenario,
io_uring_entercalls reduced from 486 to 65 (-86.6%).