IoUring: Only complete deregistration promise once we received all co…#16330
Merged
Conversation
…mpletions Motivation: We need to ensure we only notify about the completion of the deregistration once we handled all completions. Otherwise we might produce assertion failures. Beside this we also need to ensure we always cancel the registration on deregistration even if there are no ops scheduled. Modifications: - Only notify promise once everything is handled - Always cancel registration. - Add unit test Result: Fixes #16307
Member
Author
|
/cc @doom369.. I think this should fix your problem |
Member
Author
|
The same problem exists in 5.0 but I want to do a better fix there as I can break the API ... |
Member
Author
|
This is the fix for 5.0 #16336 |
chrisvest
approved these changes
Feb 23, 2026
Contributor
|
@normanmaurer thanks! Will check with the next Netty release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…mpletions
Motivation:
We need to ensure we only notify about the completion of the deregistration once we handled all completions. Otherwise we might produce assertion failures. Beside this we also need to ensure we always cancel the registration on deregistration even if there are no ops scheduled.
Modifications:
Result:
Fixes #16307