Fix RunInFastThreadLocalThreadExtension#16314
Merged
Merged
Conversation
Motivation: This JUnit extension is meant to run all the tests in FastThreadLocalThreads. However, it did not intercept repeated or parameterized test invocations. Modification: Make the extension also intercept templated tests and dynamic tests. Result: Repeated and parameterized tests now also run in FastThreadLocalThreads when using this extension.
chrisvest
added
needs-cherry-pick-4.1
netty-project-bot
pushed a commit
that referenced
this pull request
Feb 21, 2026
Motivation: This JUnit extension is meant to run all the tests in FastThreadLocalThreads. However, it did not intercept repeated or parameterized test invocations. Modification: Make the extension also intercept templated tests and dynamic tests. Result: Repeated and parameterized tests now also run in FastThreadLocalThreads when using this extension. Co-authored-by: Norman Maurer <[email protected]> (cherry picked from commit 2530b66)
Contributor
|
Auto-port PR for 4.1: #16328 |
github-actions
Bot
removed
the
needs-cherry-pick-4.1
netty-project-bot
pushed a commit
that referenced
this pull request
Feb 21, 2026
Motivation: This JUnit extension is meant to run all the tests in FastThreadLocalThreads. However, it did not intercept repeated or parameterized test invocations. Modification: Make the extension also intercept templated tests and dynamic tests. Result: Repeated and parameterized tests now also run in FastThreadLocalThreads when using this extension. Co-authored-by: Norman Maurer <[email protected]> (cherry picked from commit 2530b66)
Contributor
|
Auto-port PR for 5.0: #16329 |
github-actions
Bot
removed
the
needs-cherry-pick-5.0
chrisvest
added a commit
that referenced
this pull request
Feb 21, 2026
Auto-port of #16314 to 5.0 Cherry-picked commit: 2530b66 --- Motivation: This JUnit extension is meant to run all the tests in FastThreadLocalThreads. However, it did not intercept repeated or parameterized test invocations. Modification: Make the extension also intercept templated tests and dynamic tests. Result: Repeated and parameterized tests now also run in FastThreadLocalThreads when using this extension. Co-authored-by: Chris Vest <[email protected]> Co-authored-by: Norman Maurer <[email protected]>
chrisvest
added a commit
that referenced
this pull request
Feb 21, 2026
Auto-port of #16314 to 4.1 Cherry-picked commit: 2530b66 --- Motivation: This JUnit extension is meant to run all the tests in FastThreadLocalThreads. However, it did not intercept repeated or parameterized test invocations. Modification: Make the extension also intercept templated tests and dynamic tests. Result: Repeated and parameterized tests now also run in FastThreadLocalThreads when using this extension. --------- Co-authored-by: Chris Vest <[email protected]> Co-authored-by: Norman Maurer <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
This JUnit extension is meant to run all the tests in FastThreadLocalThreads. However, it did not intercept repeated or parameterized test invocations.
Modification:
Make the extension also intercept templated tests and dynamic tests.
Result:
Repeated and parameterized tests now also run in FastThreadLocalThreads when using this extension.