Fix Zstd throws Exception on read-only volumes (#13978) #13982
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@danielksb did you sign our icla yet, https://netty.io/s/icla ? |
Contributor
Author
Not yet, I will do it know. |
chrisvest
approved these changes
Apr 17, 2024
Member
|
@danielksb thanks a lot! |
normanmaurer
pushed a commit
that referenced
this pull request
Apr 18, 2024
Motivation: When deploying Netty on a read-only volume (e.g, within a Docker container) with "zstd-jni" included in the classpath, initialization of zstd will fail because it requires unpacking files into a temporary directory. Therefore, it is crucial to verify whether zstd can be initialized, rather than merely checking for the presence of the library in the classpath. Modification: During the verification process for the presence of "zstd-jni" in the classpath, the system will also attempt to initialize the library. This initialization follows a pattern similar to that used for the Brotli library check. Result: Fixes #13978. Co-authored-by: Daniel Käs <[email protected]>
LuciferYang
pushed a commit
to apache/spark
that referenced
this pull request
May 28, 2024
### What changes were proposed in this pull request? The pr aims to upgrade `netty` from `4.1.109.Final` to `4.1.110.Final`. ### Why are the changes needed? - https://netty.io/news/2024/05/22/4-1-110-Final.html This version has brought some bug fixes and improvements, such as: Fix Zstd throws Exception on read-only volumes (netty/netty#13982) Add unix domain socket transport in netty 4.x via JDK16+ ([#13965](netty/netty#13965)) Backport #13075: Add the AdaptivePoolingAllocator ([#13976](netty/netty#13976)) Add no-value key handling only for form body ([#13998](netty/netty#13998)) Add support for specifying SecureRandom in SSLContext initialization ([#14058](netty/netty#14058)) - https://github.com/netty/netty/issues?q=milestone%3A4.1.110.Final+is%3Aclosed ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #46744 from panbingkun/SPARK-48420. Authored-by: panbingkun <[email protected]> Signed-off-by: yangjie01 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
When deploying Netty on a read-only volume (e.g, within a Docker container) with "zstd-jni" included in the classpath, initialization of zstd will fail because it requires unpacking files into a temporary directory. Therefore, it is crucial to verify whether zstd can be initialized, rather than merely checking for the presence of the library in the classpath.
Modification:
During the verification process for the presence of "zstd-jni" in the classpath, the system will also attempt to initialize the library. This initialization follows a pattern similar to that used for the Brotli library check.
Result:
Fixes #13978.