Skip to content

Commit ef1d588

Browse files
authored
Revert to PR build to Ubuntu 22.04 (#16595)
Motivation: The "ubuntu-latest" recently got upgraded to Ubuntu 24.04.4 (from 24.04.3) which introduced the bug described in axboe/liburing#1509 but did not bring the fix. This breaks our io_uring tests. The kernel version used in the ubuntu-latest build runners for 24.04.4 is 6.17.0-1008-azure. Modification: Revert PR build, normal build, and release builds to instead use ubuntu-22.04 build images, which are based on Ubuntu 22.04.5 and use the kernel 6.8.0-1044-azure. Result: The build should pass, but more tests might be disabled because they rely on features not supported on this older kernel version.
1 parent 6cef4ea commit ef1d588

6 files changed

Lines changed: 11 additions & 13 deletions

File tree

.github/workflows/ci-build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ concurrency:
3939

4040
jobs:
4141
build:
42-
runs-on: ubuntu-latest
42+
runs-on: ubuntu-22.04
4343
strategy:
4444
matrix:
4545
include:

.github/workflows/ci-deploy.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ concurrency:
3838

3939
jobs:
4040
stage-snapshot-linux:
41-
runs-on: ubuntu-latest
41+
runs-on: ubuntu-22.04
4242
strategy:
4343
matrix:
4444
include:
@@ -191,7 +191,7 @@ jobs:
191191
include-hidden-files: true
192192

193193
deploy-staged-snapshots:
194-
runs-on: ubuntu-latest
194+
runs-on: ubuntu-22.04
195195
# Wait until we have staged everything
196196
needs: [ stage-snapshot-linux, stage-snapshot-windows-x86_64, stage-snapshot-macos ]
197197
steps:

.github/workflows/ci-pr.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ concurrency:
3636

3737
jobs:
3838
verify-pr:
39-
runs-on: ubuntu-latest
39+
runs-on: ubuntu-22.04
4040
steps:
4141
- uses: actions/checkout@v4
4242
- name: Set up JDK 11
@@ -133,7 +133,7 @@ jobs:
133133
134134
build-pr-cross:
135135
# The host should always be Linux
136-
runs-on: ubuntu-latest
136+
runs-on: ubuntu-22.04
137137
strategy:
138138
fail-fast: false
139139
matrix:
@@ -188,7 +188,7 @@ jobs:
188188
JAVA_HOME=/usr/lib/jvm/java-11-openjdk-${{ matrix.java_arch || matrix.arch }} ./mvnw -V -B -ntp -pl testsuite-native -am clean package -DskipTests=true -Dcheckstyle.skip=true -DskipNativeTestsuite=false -Dtcnative.classifier=
189189
190190
build-pr:
191-
runs-on: ubuntu-latest
191+
runs-on: ubuntu-22.04
192192
strategy:
193193
fail-fast: false
194194
matrix:

.github/workflows/ci-release-4.2.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ concurrency:
3333

3434
jobs:
3535
prepare-release:
36-
runs-on: ubuntu-latest
36+
runs-on: ubuntu-22.04
3737
steps:
3838
- uses: actions/checkout@v4
3939
with:
@@ -85,7 +85,7 @@ jobs:
8585
include-hidden-files: true
8686

8787
stage-release-linux:
88-
runs-on: ubuntu-latest
88+
runs-on: ubuntu-22.04
8989
needs: prepare-release
9090
strategy:
9191
matrix:
@@ -367,7 +367,7 @@ jobs:
367367
run: ./.github/scripts/release_rollback.ps1 release.properties netty/netty 4.2
368368

369369
deploy-staged-release:
370-
runs-on: ubuntu-latest
370+
runs-on: ubuntu-22.04
371371
# Wait until we have staged everything
372372
needs: [ stage-release-linux, stage-release-macos, stage-release-windows]
373373
steps:

.github/workflows/ci-verify-load.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ concurrency:
3636

3737
jobs:
3838
install-jars-linux-aarch64:
39-
runs-on: ubuntu-latest
39+
runs-on: ubuntu-22.04
4040
steps:
4141
- uses: actions/checkout@v4
4242

@@ -66,7 +66,7 @@ jobs:
6666

6767
load-native-linux-aarch64:
6868
# The host should always be Linux
69-
runs-on: ubuntu-latest
69+
runs-on: ubuntu-22.04
7070
needs: [ install-jars-linux-aarch64 ]
7171
steps:
7272
- uses: actions/checkout@v4

transport-native-io_uring/src/test/java/io/netty/channel/uring/IoUringDomainSocketFdTest.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@
2727
import io.netty.testsuite.transport.TestsuitePermutation;
2828
import io.netty.testsuite.transport.socket.AbstractSocketTest;
2929
import io.netty.util.ReferenceCountUtil;
30-
import org.junit.jupiter.api.Disabled;
3130
import org.junit.jupiter.api.Test;
3231
import org.junit.jupiter.api.TestInfo;
3332
import org.junit.jupiter.api.Timeout;
@@ -54,7 +53,6 @@ protected List<TestsuitePermutation.BootstrapComboFactory<ServerBootstrap, Boots
5453
return IoUringSocketTestPermutation.INSTANCE.domainSocket();
5554
}
5655

57-
@Disabled
5856
@Test
5957
@Timeout(value = 30000, unit = TimeUnit.MILLISECONDS)
6058
public void testSendRecvFd(TestInfo testInfo) throws Throwable {

0 commit comments

Comments
 (0)