Epoll: Cleanup code to always return negative value on failure (#16591)

normanmaurer · web-flow · commit ec36e8ce0806 · 2026-04-03T16:33:53.000-07:00
Motivation:

We usually use a negative value in case of an error but did not in one
case. While this does not really matters in practise as weput an
exception on the call stack we should be consistent.

Modifications:

Return negative value on fcntl failure

Result:

More consistent code base
diff --git a/transport-native-epoll/src/main/c/netty_epoll_native.c b/transport-native-epoll/src/main/c/netty_epoll_native.c
@@ -243,7 +243,7 @@ static jint netty_epoll_native_epollCreate(JNIEnv* env, jclass clazz) {
             int err = errno;
             close(efd);
             netty_unix_errors_throwChannelExceptionErrorNo(env, "fcntl() failed: ", err);
-            return err;
+            return -err;
         }
     }
     return efd;

Original file line number	Diff line number	Diff line change
`@@ -243,7 +243,7 @@ static jint netty_epoll_native_epollCreate(JNIEnv* env, jclass clazz) {`
`243`	`243`	`int err = errno;`
`244`	`244`	`close(efd);`
`245`	`245`	`netty_unix_errors_throwChannelExceptionErrorNo(env, "fcntl() failed: ", err);`
`246`		`- return err;`
	`246`	`+ return -err;`
`247`	`247`	`}`
`248`	`248`	`}`
`249`	`249`	`return efd;`