Short-circuit ByteBuf::release (#13782)

franz1981 · web-flow · commit e2859f4f42cb · 2024-01-19T10:51:39.000+01:00
Motivation:

ReferenceCountUtil::safeRelease can both hit interface virtual calls and
requires checking for an interface type (ReferenceCounted)

Modifications:

Perform a class check to save both.

Result:

Faster buffers release
diff --git a/transport/src/main/java/io/netty/channel/ChannelOutboundBuffer.java b/transport/src/main/java/io/netty/channel/ChannelOutboundBuffer.java
@@ -15,6 +15,7 @@
  */
 package io.netty.channel;
 
+import io.netty.buffer.AbstractReferenceCountedByteBuf;
 import io.netty.buffer.ByteBuf;
 import io.netty.buffer.ByteBufHolder;
 import io.netty.buffer.Unpooled;
@@ -275,9 +276,20 @@ public boolean remove() {
 
         removeEntry(e);
 
+        // only release message, notify and decrement if it was not canceled before.
         if (!e.cancelled) {
-            // only release message, notify and decrement if it was not canceled before.
-            ReferenceCountUtil.safeRelease(msg);
+            // this save both checking against the ReferenceCounted interface
+            // and makes better use of virtual calls vs interface ones
+            if (msg instanceof AbstractReferenceCountedByteBuf) {
+                try {
+                    // release now as it is flushed.
+                    ((AbstractReferenceCountedByteBuf) msg).release();
+                } catch (Throwable t) {
+                    logger.warn("Failed to release a ByteBuf: {}", msg, t);
+                }
+            } else {
+                ReferenceCountUtil.safeRelease(msg);
+            }
             safeSuccess(promise);
             decrementPendingOutboundBytes(size, false, true);
         }
