Fix OpenSslClientSessionCache remove (#14366)

chrisvest · web-flow · commit bbd3a4a50ed2 · 2024-09-23T21:00:44.000-07:00
Motivation:
Loop was adding `nativeSslSession` to the `toBeRemoved` list, instead of
the loop variable `sslSession`.

Modification:
Add the loop variable instead, because the `nativeSslSession` can very
likely be null at that point, and is specifically also not the session
we want to remove.

Result:
Fewer bugs in SSL session caching
diff --git a/handler/src/main/java/io/netty/handler/ssl/OpenSslClientSessionCache.java b/handler/src/main/java/io/netty/handler/ssl/OpenSslClientSessionCache.java
@@ -99,7 +99,7 @@ boolean setSession(long ssl, OpenSslSession session, String host, int port) {
                     if (toBeRemoved == null) {
                         toBeRemoved = new ArrayList<NativeSslSession>(2);
                     }
-                    toBeRemoved.add(nativeSslSession);
+                    toBeRemoved.add(sslSession);
                 }
             }
 

Original file line number	Diff line number	Diff line change
`@@ -99,7 +99,7 @@ boolean setSession(long ssl, OpenSslSession session, String host, int port) {`
`99`	`99`	`if (toBeRemoved == null) {`
`100`	`100`	`toBeRemoved = new ArrayList<NativeSslSession>(2);`
`101`	`101`	`}`
`102`		`- toBeRemoved.add(nativeSslSession);`
	`102`	`+ toBeRemoved.add(sslSession);`
`103`	`103`	`}`
`104`	`104`	`}`
`105`	`105`