Merge commit from fork

normanmaurer · web-flow · commit 3d45a1e4e8eb · 2026-06-01T18:34:40.000+02:00
HTTP2: DelegatingDecompressorFrameListener must release memory in all cases
Motivation:

We need to ensure we also release the buffer if the flow controller for example throws, missing to do so might result in OOME.

Modifications:

Move buf.release() to finally block

Result:

Always release buffer
diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/DelegatingDecompressorFrameListener.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/DelegatingDecompressorFrameListener.java
@@ -387,19 +387,22 @@ public void channelRead(ChannelHandlerContext ctx, Object msg) throws Exception
                         return;
                     }
 
-                    // Also take padding into account.
-                    incrementDecompressedBytes(padding);
-
-                    incrementDecompressedBytes(buf.readableBytes());
-                    // Immediately return the bytes back to the flow controller. ConsumedBytesConverter will convert
-                    // from the decompressed amount which the user knows about to the compressed amount which flow
-                    // control knows about.
-                    connection.local().flowController().consumeBytes(stream,
-                            listener.onDataRead(targetCtx, stream.id(), buf, padding, false));
-                    padding = 0; // Padding is only communicated once on the first iteration.
-                    buf.release();
-
-                    dataDecompressed = true;
+                    try {
+                        // Also take padding into account.
+                        incrementDecompressedBytes(padding);
+
+                        incrementDecompressedBytes(buf.readableBytes());
+                        // Immediately return the bytes back to the flow controller. ConsumedBytesConverter will convert
+                        // from the decompressed amount which the user knows about to the compressed amount which flow
+                        // control knows about.
+                        connection.local().flowController().consumeBytes(stream,
+                                listener.onDataRead(targetCtx, stream.id(), buf, padding, false));
+                        padding = 0; // Padding is only communicated once on the first iteration.
+
+                        dataDecompressed = true;
+                    } finally {
+                        buf.release();
+                    }
                 }
 
                 @Override
