Skip to content

FileSystem: add resolvePath #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JanTvrdik wants to merge 3 commits into from
Closed

FileSystem: add resolvePath #308

JanTvrdik wants to merge 3 commits into from

Conversation

@JanTvrdik
Copy link
Contributor

@JanTvrdik JanTvrdik commented Feb 17, 2024

  • new feature
  • BC break: no

This a port of path.resolve from Node.js.

In reality I only need sth like

public static function resolvePath(string $a, string $b): string
{
	return self::isAbsolute($b) ? $b : self::joinPaths($a, $b);
}

so I'm not sure how useful the more general implementation is.

@JanTvrdik JanTvrdik mentioned this pull request Mar 14, 2024
Merged
@dg dg force-pushed the master branch 2 times, most recently from b080db7 to d668e02 Compare May 3, 2024 11:20
@dg dg force-pushed the master branch 4 times, most recently from 1e73622 to d6a9961 Compare May 16, 2024 20:06
@dg dg force-pushed the master branch 14 times, most recently from 6733224 to 5de10a1 Compare June 18, 2024 21:22
@dg dg force-pushed the master branch 5 times, most recently from 1ce0dab to a3120d7 Compare August 7, 2024 10:08
@dg dg force-pushed the master branch 11 times, most recently from a846fab to 736c567 Compare August 7, 2024 16:18
@dg dg force-pushed the master branch 2 times, most recently from cd9170e to 2b48b24 Compare December 12, 2024 10:02
@dg dg force-pushed the master branch 2 times, most recently from 6f1918e to be53471 Compare February 3, 2025 00:59
@dg dg force-pushed the master branch 4 times, most recently from 3d22b9b to ba103e3 Compare March 30, 2025 21:02
@dg dg closed this in 259c2bf Mar 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JanTvrdik @dg