Skip to content

Reflection::getParameterDefaultValue() fixed constants parsing in namespaced scope#129

Merged
dg merged 1 commit into
nette:masterfrom
xificurk:reflection-parameter-default-value
Jan 13, 2017
Merged

Reflection::getParameterDefaultValue() fixed constants parsing in namespaced scope#129
dg merged 1 commit into
nette:masterfrom
xificurk:reflection-parameter-default-value

Conversation

@xificurk
Copy link
Copy Markdown
Contributor

@xificurk xificurk commented Jan 11, 2017

  • bug fix? yes
  • new feature? no
  • BC break? no
  • doc PR: not needed

Reflection::getParameterDefaultValue() does not properly resolve global constants used as default parameter values in namespaced classes.

@xificurk
Copy link
Copy Markdown
Contributor Author

@xificurk xificurk changed the title Failing test for Reflection::getParameterDefaultValue() Reflection::getParameterDefaultValue() fixed constants parsing in namespaced scope Jan 11, 2017
@xificurk xificurk force-pushed the reflection-parameter-default-value branch from 9e80836 to 7229d32 Compare January 11, 2017 21:16
@dg
Copy link
Copy Markdown
Member

dg commented Jan 13, 2017

Thanks!

@dg dg merged commit 1661ec5 into nette:master Jan 13, 2017
@xificurk xificurk deleted the reflection-parameter-default-value branch January 13, 2017 06:11
dg pushed a commit that referenced this pull request Jan 13, 2017
dg pushed a commit that referenced this pull request Jan 13, 2017
dg pushed a commit that referenced this pull request Jan 14, 2017
dg pushed a commit that referenced this pull request Jan 14, 2017
dg pushed a commit that referenced this pull request Jan 14, 2017
dg pushed a commit that referenced this pull request Jan 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants