added fromEmail option to set From header#109
Conversation
Useful for hostings where From email headers in php mail() are restricted to concrete ones. Can be configured through neon.
Managed to fix whitespaces :)
There was a problem hiding this comment.
I don't like this new property and I see no reason for the debugger to be concerned about what the Logger is doing.
There was a problem hiding this comment.
But it already is by managing logDirectory and email.
There was a problem hiding this comment.
That's for BC, I don't see any reason to introduce more properties like this on the Debugger.
There was a problem hiding this comment.
But it will not be able to configure it from neon in 'debugger' section, will it?
There was a problem hiding this comment.
Ok, it does not need to be passed to Logger class but it must stay as property in Debugger class. (I am going to push new commit about this in few sec). Because when I want to configure fromEmail in neon from 'debugger' section it must be declared as static property in Debugger class, or am I wrong?
|
Logger::$fromEmail is OK, but please do not add new argument to methods. |
4 participants
Useful for hosting where From email headers in php mail() are
restricted to concrete ones. Can be configured through neon.