Skip to content

Dumper: changed $maxDepth to 10 and every (nonempty) object is dumped only once#207

Merged
dg merged 1 commit into
nette:masterfrom
dg:smarter-dump
Feb 4, 2015
Merged

Dumper: changed $maxDepth to 10 and every (nonempty) object is dumped only once#207
dg merged 1 commit into
nette:masterfrom
dg:smarter-dump

Conversation

@dg
Copy link
Copy Markdown
Member

@dg dg commented Feb 3, 2015

[Closes #204]

@hrach
Copy link
Copy Markdown

hrach commented Feb 3, 2015

Works great! It's fast (comparing to the smaller depth) and actual file has just 1300 lines.

… only once [Closes nette#204]

Note: SplObjectStorage is not used because is buggy in PHP 5.3.3
@milo
Copy link
Copy Markdown
Member

milo commented Feb 4, 2015

@dg Tested. Looks nice.

dg added a commit that referenced this pull request Feb 4, 2015
Dumper: changed $maxDepth to 10 and every (nonempty) object is dumped only once
@dg dg merged commit b0c5259 into nette:master Feb 4, 2015
@dg dg deleted the smarter-dump branch February 4, 2015 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Recursion while dumping assert exception

3 participants