Hi,
interface Nette\Security\Authenticator has two string parameters: $user and $password. The name of the parameter $user may led to naming confusion in this cases:
a) with Nette\Security\User which is by default present in Nette presenters like $presenter->user and in Nette templates like $user
b) with the database table user - it is a common practice use table user with field username (login) for authentication
Therefore I propose to change the name of the parameter $user to $username like this:
interface Authenticator
{
.......
function authenticate(string $username, string $password): IIdentity;
}
github:
|
function authenticate(string $user, string $password): IIdentity; |
Hi,
interface Nette\Security\Authenticator has two string parameters: $user and $password. The name of the parameter $user may led to naming confusion in this cases:
a) with Nette\Security\User which is by default present in Nette presenters like $presenter->user and in Nette templates like $user
b) with the database table user - it is a common practice use table user with field username (login) for authentication
Therefore I propose to change the name of the parameter $user to $username like this:
github:
security/src/Security/Authenticator.php
Line 41 in 0458647