RequestFactory: extract port from x-forwarded-host #230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dg
force-pushed
the
master
branch
5 times, most recently
from
55488bd to
2042d2e
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
4960652 to
5e67add
Compare
Member
|
Thanks |
dg
pushed a commit
that referenced
this pull request
Nov 4, 2024
dg
pushed a commit
that referenced
this pull request
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unification of host and port parsing was added in #229. Initially, I was uncertain whether the distinct parsing approaches for the
HostandX-Forwardedheaders compared to theX-Forwarded-Hostheader were intentional, since theX-Forwarded-*headers lack a formal specification. However, it's commonly observed that theX-Forwarded-Hostheader may contain the value of theHostheader, which may include the port. Currently, if this header includes both the host and the port, the entire string is simply stored in the host field of the resulting URL. The goal of this PR is to parse this header using theparseHostAndPortmethod, to ensure that the port is correctly separated and stored into the port field.Since this PR uses the method added in #229 it's based on the commit that was merged into the master branch.