Added support for setting priority of config files#26
Closed
richard-ejem wants to merge 1 commit into
Closed
Conversation
Contributor
|
I don't like this. |
Author
|
@fprochazka can you tell what's wrong with that? |
Member
|
Better solution is to allow |
Author
|
Ok I'll fix it :) Dne neděle 26. října 2014 David Grudl [email protected] napsal(a):
|
richard-ejem
force-pushed
the
master
branch
2 times, most recently
from
55cdb1d to
61faeff
Compare
Author
|
Fixed. now it is much simpler :) not even needing its counterpart in nette/bootstrap, I can remove that other pull request now |
Member
|
This is not correct due to di/src/DI/ContainerFactory.php Line 74 in 61faeff |
dg
added a commit
that referenced
this pull request
Nov 8, 2014
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configuration in parameters section of config files had hardcoded higher priority than configuration passed from parameters array passed to Compiler::compile.
I found this unhandy, because sometimes I need to override some configuration from config files in my bootstrap. It seems more logical for me that dynamically built parameters in bootstrap.php have higher priority than static config files.
For backwards compatibility, I've made this behavior optional, configurable by ContainerFactory::$configPriority.
I issued another pull request for nette/bootstrap, which which should allow to set $configurator->configPriority in bootstrap without needing to manually call ContainerFactory.