Skip to content

PhpGenerator: $name might not be defined#212

Merged
dg merged 2 commits into
nette:masterfrom
janbarasek:janbarasek-name-defined
Jul 19, 2019
Merged

PhpGenerator: $name might not be defined#212
dg merged 2 commits into
nette:masterfrom
janbarasek:janbarasek-name-defined

Conversation

@janbarasek
Copy link
Copy Markdown
Contributor

@janbarasek janbarasek commented Jul 18, 2019

  • bug fix
  • BC break? no

Solve:

 ------ -------------------------------------- 
  Line   DI/PhpGenerator.php                   
 ------ -------------------------------------- 
  99     Variable $name might not be defined.  
 ------ --------------------------------------

@f3l1x
Copy link
Copy Markdown
Member

f3l1x commented Jul 18, 2019

Hi. It is great you improving nette/di. I would suggest next time to join all changes to one PR, further codereview will be much easier.

@janbarasek
Copy link
Copy Markdown
Contributor Author

janbarasek commented Jul 18, 2019

@f3l1x I am very sorry for it. I thought it was better to check all the micro-fixations separate.

@dg
Copy link
Copy Markdown
Member

dg commented Jul 19, 2019

Thanks

@dg dg merged commit f932c52 into nette:master Jul 19, 2019
dg pushed a commit that referenced this pull request Jul 19, 2019
@janbarasek @dg
fixed bugs reported by PhpStan (#212)
7ee3727 
* PhpGenerator: $name might not be defined
* ContainerPanel: elapsedTime can be float.
dg pushed a commit that referenced this pull request Jul 19, 2019
@janbarasek @dg
fixed bugs reported by PhpStan (#212)(#211)
0768bda
dg pushed a commit that referenced this pull request Jul 19, 2019
@janbarasek @dg
fixed bugs reported by PhpStan (#212)(#211)(#210)
b365d4c
@dg
Copy link
Copy Markdown
Member

dg commented Jul 19, 2019

thought it was better to check all the micro-fixations separate.

It is certainly better to do it as a separate comittes, but it can be in one PR. It could be more comfortable for you.

Sometimes I will join some commits when it is the same type of editing in different files etc…

dg pushed a commit that referenced this pull request Jul 19, 2019
@janbarasek @dg
fixed bugs reported by PhpStan (#212)(#211)(#210)(#208)
2378ea6
dg pushed a commit that referenced this pull request Jul 19, 2019
@janbarasek @dg
fixed bugs reported by PhpStan (#212)(#211)(#210)(#208)(#207)
a37036c
dg pushed a commit that referenced this pull request Jul 19, 2019
@janbarasek @dg
fixed bugs reported by PhpStan (#212)(#211)(#210)(#208)(#207)(#213)
c60c7ff
dg pushed a commit that referenced this pull request Jul 19, 2019
@janbarasek @dg
fixed bugs reported by PhpStan (#212)(#211)(#210)(#208)(#207)(#213)
fecd1fb
dg pushed a commit that referenced this pull request Jul 19, 2019
@janbarasek @dg
fixed bugs reported by PhpStan (#212)(#211)(#210)(#208)(#207)(#213)
15978c3
dg pushed a commit that referenced this pull request Aug 7, 2019
@janbarasek @dg
fixed bugs reported by PhpStan (#212)(#211)(#210)(#208)(#207)(#213)
1a47803
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@janbarasek @f3l1x @dg