ci: drop integration.yml — superseded by go-check#579
Conversation
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned Files
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Automated approval for maintainer PR
All automated quality gates passed. See SECURITY_CONTROLS.md for compensating controls.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #579 +/- ##
==========================================
- Coverage 87.24% 87.19% -0.06%
==========================================
Files 88 88
Lines 10625 10625
==========================================
- Hits 9270 9264 -6
- Misses 1115 1119 +4
- Partials 240 242 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Removes the repository-specific Integration GitHub Actions workflow because integration tests are already executed via the reusable go-check workflow in ci.yml.
Changes:
- Delete
.github/workflows/integration.yml(standalone integration-test workflow) - Rely on
.github/workflows/ci.yml’sgo-checkreusable workflow withenable-integration-tests: truefor integration test execution
Comments suppressed due to low confidence (1)
.github/workflows/integration.yml:1
- PR description says this removal eliminates the last inline
step-security/harden-runnerreference, but.github/workflows/codeql.ymlstill pinsstep-security/harden-runnerin thedetectjob. Consider updating the description or addressing that remaining reference so the PR matches its stated goal.
…tests Previously integration.yml ran `go test -tags=integration` with a bespoke harden-runner + setup-buildx setup. With go-check.yml now supporting `enable-integration-tests: true` (set in this repo's ci.yml), the same invocation runs inside the reusable workflow and uploads coverage to Codecov under the `integration` flag. This also removes the last inline harden-runner reference on ofelia, so Dependabot's harden-runner bumps (e.g. #576) are fully handled by netresearch/.github updates and no longer surface per-repo. Signed-off-by: Sebastian Mendel <[email protected]>
CybotTM
force-pushed
the
ci/drop-redundant-integration-yml
branch
from
88e8de9 to
18d0999
Compare
There was a problem hiding this comment.
Automated approval for maintainer PR
All automated quality gates passed. See SECURITY_CONTROLS.md for compensating controls.
Redundant with go-check's
enable-integration-tests: truealready set in ci.yml. Removing kills the last inline harden-runner reference on ofelia (so #576 and future similar Dependabot PRs are fully handled by netresearch/.github updates).