Skip to content

Docker SDK: document remaining undocumented config keys (notification-cooldown, smtp-tls-skip-verify, webhook-*) #635

@CybotTM

Description

@CybotTM

Surfaced during sibling-bug hunt for #631.

PR #631 reconciled Slack/Save docs drift. Five more struct tags are still undocumented:

Key Source What it does
`notification-cooldown` `cli/config.go:72` Notification deduplication cooldown period
`smtp-tls-skip-verify` `middlewares/mail.go:27` Disable SMTP TLS verification
`webhook-webhooks` `middlewares/webhook_config.go:72` Default webhook list applied to every job
`webhook-trusted-preset-sources` `middlewares/webhook_config.go:79` Allow-list for remote preset URLs
`webhook-preset-cache-dir` `middlewares/webhook_config.go:85` Directory for preset cache

`webhook-webhooks` is documented in PR #631's expanded README, but the others have NO doc mention.

Asks

  • Add each to `docs/CONFIGURATION.md` global settings section with default + semantics.
  • Add `webhook-*` keys to `docs/webhooks.md`.
  • Add `smtp-tls-skip-verify` to mail section + a TROUBLESHOOTING note about its security trade-off.
  • Once added, the existing `TestConfigGlobalKeysAreDocumented` reflection test will start passing for them.

Severity

Low — silent features, no security impact (`smtp-tls-skip-verify` is operator-visible; the others are operational).

Related

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions