use the same type for all time_group_value values #21528
Merged
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilyam8
requested review from
Copilot
and removed request for
thiagoftsm and
vkalintiris
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
This PR standardizes the JSON schema type definition for time_group_value fields from "integer" to "number" across all conditional schemas in the health alert prototype configuration. This ensures consistency and allows for fractional values where appropriate (e.g., percentiles like 95.5 or trim percentages like 2.5%).
- Standardizes type definitions across all
time_group_valuefields to use "number" instead of "integer" - Aligns three conditional schemas (trimmed-mean, trimmed-median, percentile) with the existing "countif" schema that already used "number"
- Enables more precise configuration of alert thresholds and statistical calculations
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
stelfrag
approved these changes
Jan 9, 2026
stelfrag
pushed a commit
to stelfrag/netdata
that referenced
this pull request
Jan 9, 2026
(cherry picked from commit d9fe0b9)
stelfrag
pushed a commit
to stelfrag/netdata
that referenced
this pull request
Jan 9, 2026
(cherry picked from commit d9fe0b9)
Merged
Ferroin
pushed a commit
that referenced
this pull request
Jan 12, 2026
(cherry picked from commit d9fe0b9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
Additional Information
For users: How does this change affect me?
Summary by cubic
Standardized the health alert schema to use the 'number' type for time_group_value in all cases. This fixes validation mismatches and allows decimal values for trim and percentage groups.
Written for commit 158877b. Summary will update on new commits.