fix(edit-config): ignore container variable inherited from /etc/profile #21505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/packaging
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where the edit-config script fails in LXC containers due to an inherited container environment variable from /etc/profile being mistakenly treated as a command.
Key Changes:
- Preserve caller-provided
containervariable before sourcing/etc/profile - Restore the original value after sourcing, or unset it if it wasn't initially set
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
stelfrag
approved these changes
Dec 27, 2025
stelfrag
pushed a commit
to stelfrag/netdata
that referenced
this pull request
Jan 9, 2026
…le (netdata#21505) Co-authored-by: Copilot <[email protected]> (cherry picked from commit 17bfcfe)
stelfrag
pushed a commit
to stelfrag/netdata
that referenced
this pull request
Jan 9, 2026
…le (netdata#21505) Co-authored-by: Copilot <[email protected]> (cherry picked from commit 17bfcfe)
Merged
Ferroin
pushed a commit
that referenced
this pull request
Jan 12, 2026
…le (#21505) Co-authored-by: Copilot <[email protected]> (cherry picked from commit 17bfcfe)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #21504
Issue:
edit-configsources/etc/profile, which may define a container environment variable (e.g.container=lxcin LXC environments).If
containeris not explicitly set by the caller, this inherited value is later treated as a command, causing failures.Fix:
Preserve the container variable only if it was explicitly set by the caller before sourcing
/etc/profile.Test Plan
Additional Information
For users: How does this change affect me?
Summary by cubic
Prevent edit-config from using a container value inherited from /etc/profile unless the caller set it. This avoids failures where inherited values (e.g., container=lxc) are treated as commands.
Written for commit bdae96f. Summary will update automatically on new commits.