fix(go.d/vnodes): add additionalProperties to config_schema.json #21503
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/collectors
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds the additionalProperties constraint to the labels field in the virtual node configuration schema to properly validate that label values must be strings. This aligns the JSON schema with the Go code implementation (map[string]string) and follows the established pattern used in other collectors throughout the codebase.
Key Changes:
- Added
additionalPropertieswithtype: "string"constraint to thelabelsfield schema
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
stelfrag
approved these changes
Dec 26, 2025
vkalintiris
approved these changes
Dec 26, 2025
stelfrag
pushed a commit
to stelfrag/netdata
that referenced
this pull request
Jan 9, 2026
…data#21503) (cherry picked from commit 22ab245)
stelfrag
pushed a commit
to stelfrag/netdata
that referenced
this pull request
Jan 9, 2026
…data#21503) (cherry picked from commit 22ab245)
Merged
Ferroin
pushed a commit
that referenced
this pull request
Jan 12, 2026
) (cherry picked from commit 22ab245)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
Additional Information
For users: How does this change affect me?
Summary by cubic
Updated the go.d vnodes config schema to allow labels with arbitrary keys and string values, fixing validation failures in dynamic config.
Written for commit 80ad3a7. Summary will update automatically on new commits.