chore(go.d): include Go version in build info #21473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/collectors
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds the Go version to the build information output in the go.d plugin, allowing users and developers to identify which version of Go was used to compile the plugin.
Key changes:
- Modified
Info()function to includego_versionfield in the output string usingruntime.Version()
Comments suppressed due to low confidence (1)
src/go/pkg/buildinfo/buildinfo.go:41
- The Info() function now includes the Go version in its output, but there are no tests to verify this behavior. Consider adding a test to ensure the go_version field is included in the output and that runtime.Version() is called correctly.
func Info() string {
return fmt.Sprintf(
"version=%s go_version=%s user_config_dir=%s stock_config_dir=%s plugins_dir=%s netdata_bin_dir=%s",
Version,
runtime.Version(),
UserConfigDir,
StockConfigDir,
PluginsDir,
NetdataBinDir,
)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
stelfrag
approved these changes
Dec 16, 2025
stelfrag
pushed a commit
to stelfrag/netdata
that referenced
this pull request
Dec 17, 2025
(cherry picked from commit 79b7982)
Merged
Ferroin
pushed a commit
that referenced
this pull request
Dec 17, 2025
(cherry picked from commit 79b7982)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
Additional Information
For users: How does this change affect me?
Summary by cubic
Include the Go runtime version in go.d build info to improve diagnostics and environment visibility. The Info() string now includes a go_version key alongside version and existing paths.
Written for commit 40d9f79. Summary will update automatically on new commits.