Fix validation of extent index in journal file #21400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
thiagoftsm
approved these changes
Dec 4, 2025
Contributor
thiagoftsm
left a comment
thiagoftsm
left a comment
There was a problem hiding this comment.
After two hours running, no issues were found locally. LGTM!
stelfrag
added a commit
to stelfrag/netdata
that referenced
this pull request
Dec 5, 2025
(cherry picked from commit b50bc52)
Merged
Ferroin
pushed a commit
that referenced
this pull request
Dec 15, 2025
(cherry picked from commit b50bc52)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Summary by cubic
Fix off‑by‑one validation in journal v2: extent_index equal to extent_entries is now treated as invalid. Prevents out‑of‑bounds page access and ensures correct error logging when parsing the journal.
Written for commit ac06222. Summary will update automatically on new commits.