Skip to content

Conversation

@stelfrag
Copy link
Collaborator

@stelfrag stelfrag commented Dec 3, 2025

Summary
  • Handle spurious wakeups when waiting for a completion

Summary by cubic

Fixed timed wait in completion to handle spurious wakeups and respect shutdown timeouts. Prevents premature timeouts or hanging during shutdown.

  • Bug Fixes
    • Use an absolute deadline and compute remaining timeout each loop.
    • Re-check completion after each wake to ignore spurious wakeups.
    • Enforce a minimum 1 ns timeout when zero is passed.

Written for commit 6a88f34. Summary will update automatically on new commits.

@stelfrag stelfrag marked this pull request as ready for review December 3, 2025 14:25
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Copy link
Contributor

@thiagoftsm thiagoftsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found during shutdown. LGTM!

@stelfrag stelfrag merged commit edb587b into netdata:master Dec 4, 2025
119 checks passed
@stelfrag stelfrag deleted the fix_shutdown_timeout branch December 4, 2025 07:17
stelfrag added a commit to stelfrag/netdata that referenced this pull request Dec 5, 2025
@stelfrag stelfrag mentioned this pull request Dec 5, 2025
Ferroin pushed a commit that referenced this pull request Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants