Improve stale replication #21357
Merged
Improve stale replication #21357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@stelfrag I've started the AI code review. It'll take a few minutes to complete. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
2 issues found across 3 files
Prompt for AI agents (all 2 issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="src/plugins.d/pluginsd_replication.c">
<violation number="1" location="src/plugins.d/pluginsd_replication.c:491">
`is_empty_response` checks the requested range instead of the child’s actual data, so empty-response detection never activates and stalled replications remain unresolved.</violation>
</file>
<file name="src/streaming/stream-replication-sender.c">
<violation number="1" location="src/streaming/stream-replication-sender.c:1250">
The empty-response path frees the sender buffer instead of committing it, so no REPLAY_END message is ever sent and the parent stays blocked.</violation>
</file>
Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@stelfrag I've started the AI code review. It'll take a few minutes to complete. |
Contributor
There was a problem hiding this comment.
1 issue found across 4 files
Prompt for AI agents (all 1 issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="src/streaming/stream-replication-sender.c">
<violation number="1" location="src/streaming/stream-replication-sender.c:451">
Splitting a response because of max buffer size must never leave `enable_streaming` true; otherwise we mark replication finished even though part of the requested interval was dropped, permanently losing data.</violation>
</file>
Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@stelfrag I've started the AI code review. It'll take a few minutes to complete. |
stelfrag
requested review from
Ferroin,
thiagoftsm and
vkalintiris
as code owners
thiagoftsm
approved these changes
Nov 28, 2025
Contributor
thiagoftsm
left a comment
thiagoftsm
left a comment
There was a problem hiding this comment.
Replication is working as expected locally. I stopped parent some time and after its restart, gap on parent was filled as expected. LGTM!
stelfrag
added a commit
to stelfrag/netdata
that referenced
this pull request
Dec 1, 2025
* Implement stuck replication detection and response handling * Fix checks and commit response for not found chart * Initialize replication stuck detection counter and refine replication completion conditions * Refine streaming response handling to prevent data loss during buffer overflow (cherry picked from commit c643895)
Merged
Ferroin
pushed a commit
that referenced
this pull request
Dec 3, 2025
* Implement stuck replication detection and response handling * Fix checks and commit response for not found chart * Initialize replication stuck detection counter and refine replication completion conditions * Refine streaming response handling to prevent data loss during buffer overflow (cherry picked from commit c643895)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Summary by cubic
Stops replication from stalling by detecting empty-response loops and safely forcing completion when appropriate. This unblocks stuck charts and makes replication finish reliably.
Written for commit 85ec862. Summary will update automatically on new commits.