Improve replication logic by checking if parent is caught up with child #21352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
thiagoftsm
approved these changes
Nov 26, 2025
Contributor
thiagoftsm
left a comment
thiagoftsm
left a comment
There was a problem hiding this comment.
Replication is running as expected locally, LGTM!
stelfrag
added a commit
to stelfrag/netdata
that referenced
this pull request
Dec 1, 2025
…ld (netdata#21352) (cherry picked from commit 9bfd83d)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Summary by cubic
Stop replication when the parent is caught up with or ahead of the child by checking last_entry_t >= child last_entry_t and sending an empty request to end the replay. This prevents stalls and avoids unnecessary gap-filling when timelines are equal or the parent is ahead.
Written for commit e0d8e26. Summary will update automatically on new commits.