fix(go.d): prefer env-provided dirs over build-time defaults #21345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/collectors
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the configuration directory priority logic to prefer environment-provided directories over build-time defaults. The change ensures that runtime environment variables take precedence when determining configuration paths.
Key Changes:
- Reversed priority order to check environment variables before buildinfo constants
- Updated comments to reflect the new precedence rules
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
stelfrag
approved these changes
Nov 24, 2025
Merged
Ferroin
pushed a commit
that referenced
this pull request
Dec 3, 2025
(cherry picked from commit a7cd2fe)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #21343
Test Plan
Additional Information
For users: How does this change affect me?
Summary by cubic
Prioritizes environment-provided config directories in go.d over build-time defaults, so runtime overrides take effect. In terminal runs, ignores env-provided dirs and watch path to prevent accidental overrides.
Written for commit 9fb07ce. Summary will update automatically on new commits.