Skip to content

Conversation

@ilyam8
Copy link
Member

@ilyam8 ilyam8 commented Nov 22, 2025

Summary
Test Plan
Additional Information
For users: How does this change affect me?

Summary by cubic

Silenced Redis client library logging in the go.d Redis collector by setting a noop logger. This reduces log noise without changing metrics collection or behavior.

Written for commit b67aaf1. Summary will update automatically on new commits.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR disables logging from the Redis client library by implementing and setting a no-op logger. This prevents the Redis library from producing unwanted log output during Netdata's Redis data collection.

  • Implemented a noopLogger type with an empty Printf method
  • Configured the Redis library to use the noopLogger in the init() function

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@ilyam8 ilyam8 enabled auto-merge (squash) November 23, 2025 21:11
@ilyam8 ilyam8 merged commit 20a5119 into netdata:master Nov 24, 2025
123 checks passed
@ilyam8 ilyam8 deleted the chore-disable-redis-logging branch November 24, 2025 09:07
stelfrag pushed a commit to stelfrag/netdata that referenced this pull request Dec 2, 2025
@stelfrag stelfrag mentioned this pull request Dec 2, 2025
Ferroin pushed a commit that referenced this pull request Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/collectors Everything related to data collection area/go collectors/go.d

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants