disable apps plugin pss mem by default #21330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilyam8
requested review from
Ancairon,
kanelatechnical and
thiagoftsm
as code owners
ilyam8
requested review from
Copilot
and removed request for
Ancairon,
kanelatechnical and
thiagoftsm
github-actions
bot
added
area/docs
area/collectors
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR disables PSS (Proportional Set Size) memory sampling by default in the apps plugin to reduce CPU overhead on systems where more accurate memory estimation is not needed.
Key Changes:
- Changed default
pss_refresh_periodfrom 300 seconds to 0 (disabled) - Updated documentation to reflect PSS sampling is now disabled by default
- Reformatted markdown tables for better alignment and readability
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/collectors/apps.plugin/apps_plugin.c |
Changed default PSS refresh period from 300 to 0 to disable PSS sampling by default |
src/collectors/apps.plugin/README.md |
Updated documentation to reflect disabled PSS default, clarified behavior, and improved table formatting |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
stelfrag
previously approved these changes
Nov 21, 2025
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
2 issues found across 2 files
Prompt for AI agents (all 2 issues)
Understand the root cause of the following 2 issues and fix them.
<file name="src/collectors/apps.plugin/apps_plugin.c">
<violation number="1" location="src/collectors/apps.plugin/apps_plugin.c:384">
Changing the default PSS refresh period to 0 disables sampling, but the CLI help text still claims the default is 5 minutes, leaving the user-facing documentation incorrect.</violation>
</file>
<file name="src/collectors/apps.plugin/README.md">
<violation number="1" location="src/collectors/apps.plugin/README.md:281">
Document now states PSS sampling is disabled by default, but the nearby "Chart behavior" list still says the default state is PSS enabled. This contradiction leaves readers unsure which behavior to expect. Please update the chart description to match the new default.</violation>
</file>
Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR
stelfrag
approved these changes
Nov 21, 2025
stelfrag
pushed a commit
to stelfrag/netdata
that referenced
this pull request
Nov 21, 2025
Co-authored-by: Copilot <[email protected]> (cherry picked from commit 74623ba)
Merged
Ferroin
pushed a commit
that referenced
this pull request
Nov 21, 2025
Co-authored-by: Copilot <[email protected]> (cherry picked from commit 74623ba)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #21289
Test Plan
Additional Information
For users: How does this change affect me?
Summary by cubic
Disable PSS memory sampling in apps.plugin by default to reduce CPU overhead. Memory charts now show RSS only unless PSS is explicitly enabled.
Written for commit afa0fb0. Summary will update automatically on new commits.