Fix compilation when DBENGINE is disabled #21323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
thiagoftsm
approved these changes
Nov 21, 2025
Contributor
thiagoftsm
left a comment
thiagoftsm
left a comment
There was a problem hiding this comment.
This PR is fixing issue in master branch when using "--disable-dbengine". LGTM!
stelfrag
added a commit
to stelfrag/netdata
that referenced
this pull request
Nov 21, 2025
(cherry picked from commit 49f117b)
Merged
Ferroin
pushed a commit
that referenced
this pull request
Nov 21, 2025
(cherry picked from commit 49f117b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #21321
Summary by cubic
Restore compilation when DBENGINE is disabled by gating the parallel host iteration behind ENABLE_DBENGINE. When DBENGINE is off, query_scope_foreach_host is used with weights_do_node_callback, skipping the parallel path.
Written for commit 97d6b42. Summary will update automatically on new commits.