fix(packagin/otel-plugin): remove cap_net_bind_service #21198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/packaging
Ferroin
previously approved these changes
Oct 23, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the cap_net_bind_service capability requirement from the otel-plugin across all packaging and installation mechanisms. The change simplifies the plugin's security model by eliminating the need for special network binding privileges.
Key Changes:
- Removed capability setting and fallback setuid logic from Debian post-installation script
- Removed capability declaration from RPM spec file
- Removed capability setting logic from the main installer script
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packaging/cmake/pkg-files/deb/plugin-otel/postinst | Removed setcap attempt and fallback chmod for cap_net_bind_service |
| netdata.spec.in | Removed %caps directive for cap_net_bind_service from RPM package definition |
| netdata-installer.sh | Removed setcap logic for cap_net_bind_service in installation script |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
thiagoftsm
approved these changes
Oct 23, 2025
stelfrag
approved these changes
Oct 23, 2025
ktsaou
pushed a commit
to ktsaou/netdata
that referenced
this pull request
Oct 24, 2025
stelfrag
pushed a commit
to stelfrag/netdata
that referenced
this pull request
Oct 27, 2025
(cherry picked from commit b74aa71)
Merged
Ferroin
pushed a commit
that referenced
this pull request
Oct 28, 2025
(cherry picked from commit b74aa71)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
Additional Information
For users: How does this change affect me?