Skip to content

Conversation

@stelfrag
Copy link
Collaborator

Summary
  • Support the ping command while the agent is initializing
    • This will allow liveness probes to understand the agent is working (initializing)
    • Allow also help and version when the agent is initializing
    • Return Agent is initializing for the rest of the commands
  • Enable the full cli once the agent has finished initialization

Support the ping command while the agent is initializing
Enable the full cli once the agent has finished initialization
@stelfrag stelfrag marked this pull request as ready for review October 22, 2025 13:18
Copy link
Contributor

@thiagoftsm thiagoftsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Netdata and netdata-cli are working as expected. LGTM!

@stelfrag stelfrag merged commit 8ca14bc into netdata:master Oct 22, 2025
115 of 116 checks passed
@stelfrag stelfrag deleted the init_cli_liveness branch October 22, 2025 18:24
stelfrag added a commit to stelfrag/netdata that referenced this pull request Oct 27, 2025
Initialize the cli command in two phases.
Support the ping command while the agent is initializing
Enable the full cli once the agent has finished initialization

(cherry picked from commit 8ca14bc)
@stelfrag stelfrag mentioned this pull request Oct 27, 2025
Ferroin pushed a commit that referenced this pull request Oct 28, 2025
Initialize the cli command in two phases.
Support the ping command while the agent is initializing
Enable the full cli once the agent has finished initialization

(cherry picked from commit 8ca14bc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants