Skip to content

Skip adding Sentry breadcrumb during shutdown timeout #21150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stelfrag merged 1 commit into from
Oct 15, 2025
Merged

Skip adding Sentry breadcrumb during shutdown timeout #21150

stelfrag merged 1 commit into from
Oct 15, 2025

Conversation

@stelfrag
Copy link
Collaborator

@stelfrag stelfrag commented Oct 15, 2025

Summary
  • Avoid adding breadcrumb during shutdown timeout to prevent crash
    • It can attempt to access information from structures that are not valid:
        memcpy (string_fortified.h:29)
        sentry__string_clone_n_unchecked (sentry_string.h:122)
        sentry__slice_to_owned (sentry_slice.c:18)
        sentry_value_set_by_key_n (sentry_value.c:477)
        reserve (sentry_value.c:124)
        sentry_value_append (sentry_value.c:547)
        sentry__value_append_bounded (sentry_value.c:643)
        sentry_add_breadcrumb (sentry_core.c:632)
        shutdown_timed_out (daemon-shutdown-watcher.c:25)

@stelfrag stelfrag marked this pull request as ready for review October 15, 2025 09:51
@stelfrag stelfrag enabled auto-merge (squash) October 15, 2025 12:01
ilyam8
ilyam8 approved these changes Oct 15, 2025
View reviewed changes
Copy link
Member

@ilyam8 ilyam8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was the only nd_sentry_add_shutdown_timeout_as_breadcrumb usage. Should we removed the function?

@stelfrag stelfrag merged commit cca892a into netdata:master Oct 15, 2025
116 checks passed
@stelfrag stelfrag deleted the fix_sentry_breadcrumb_crash branch October 15, 2025 13:11
stelfrag added a commit to stelfrag/netdata that referenced this pull request Oct 27, 2025
@stelfrag
Skip adding Sentry breadcrumb during shutdown timeout (netdata#21150)
44a07a8 
Skip adding Sentry breadcrumb during shutdown timeout to prevent crashes

(cherry picked from commit cca892a)
@stelfrag stelfrag mentioned this pull request Oct 27, 2025
Merged
Ferroin pushed a commit that referenced this pull request Oct 28, 2025
@stelfrag @Ferroin
Skip adding Sentry breadcrumb during shutdown timeout (#21150)
9cdfb5b 
Skip adding Sentry breadcrumb during shutdown timeout to prevent crashes

(cherry picked from commit cca892a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ilyam8 ilyam8 ilyam8 approved these changes

@thiagoftsm thiagoftsm Awaiting requested review from thiagoftsm thiagoftsm is a code owner

@vkalintiris vkalintiris Awaiting requested review from vkalintiris vkalintiris is a code owner

Assignees

No one assigned

Labels

area/daemon

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@stelfrag @ilyam8