improve(go.d/snmp): Add APC PowerNet-MIB sysObjectID mappings and categories #21104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/collectors
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves APC device support in SNMP profiles by adding comprehensive sysObjectID mappings and device categorization. It addresses issue #21103 by providing more specific device identification and categorization for various APC PowerNet-MIB devices.
- Reorganized APC device profiles with specific sysObjectID patterns instead of wildcards
- Added metadata categorization for different APC device types (Power, Cooling, Security, etc.)
- Consolidated vendor information in the main APC profile to avoid duplication
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| apc.yaml | Added comprehensive device metadata and category mappings for various APC device types |
| apc-ups.yaml | Updated to use specific sysObjectID patterns and removed duplicate vendor field |
| apc-pdu.yaml | Updated to use specific sysObjectID patterns and removed duplicate vendor field |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
src/go/plugin/go.d/config/go.d/snmp.profiles/default/apc-pdu.yaml
Outdated
Show resolved
Hide resolved
thiagoftsm
previously approved these changes
Oct 6, 2025
vkalintiris
previously approved these changes
Oct 6, 2025
Co-authored-by: Copilot <[email protected]>
…egories # Conflicts: # src/go/plugin/go.d/config/go.d/snmp.profiles/default/apc-pdu.yaml
ilyam8
force-pushed
the
go.d-snmp-profile-pc
branch
from
0fa230c to
5a74bad
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
thiagoftsm
approved these changes
Oct 6, 2025
stelfrag
pushed a commit
to stelfrag/netdata
that referenced
this pull request
Oct 6, 2025
…egories (netdata#21104) Co-authored-by: Copilot <[email protected]> (cherry picked from commit b16f359)
Merged
Ferroin
pushed a commit
that referenced
this pull request
Oct 15, 2025
…egories (#21104) Co-authored-by: Copilot <[email protected]> (cherry picked from commit b16f359)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #21103
Test Plan
Additional Information
For users: How does this change affect me?