improve(go.d/rabbitmq): add support for old RabbitMQ whoami tags format #21049
+31
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/collectors
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves RabbitMQ collector compatibility by handling different JSON formats for the tags field in the /whoami API response. Older RabbitMQ versions return tags as a string while newer versions return an array of strings.
- Introduces a custom JSON unmarshaller for
apiWhoamiTagstype - Supports both string and array formats for RabbitMQ tags field
- Adds null handling for the tags field
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
ralphm
previously approved these changes
Sep 25, 2025
Member
ralphm
left a comment
ralphm
left a comment
There was a problem hiding this comment.
Looks good to me. May be good to add some tests for this.
ilyam8
force-pushed
the
go.d-rabbitmq-old
branch
from
e5c28c1 to
01da129
Compare
stelfrag
approved these changes
Sep 25, 2025
stelfrag
pushed a commit
to stelfrag/netdata
that referenced
this pull request
Sep 29, 2025
…at (netdata#21049) Co-authored-by: Copilot <[email protected]> (cherry picked from commit 9a87df8)
Merged
Ferroin
pushed a commit
that referenced
this pull request
Sep 29, 2025
…at (#21049) Co-authored-by: Copilot <[email protected]> (cherry picked from commit 9a87df8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #21048
Closes: #21050
Older RabbitMQ versions return the tags field in the
/whoamiresponse as a string, while newer versions return it as an array of strings.This change introduces a custom JSON unmarshaller for apiWhoamiTags, supporting both formats to ensure compatibility with all RabbitMQ versions.
Test Plan
Additional Information
For users: How does this change affect me?