Skip status file on windows on crash (#21140)

stelfrag · web-flow · commit 9844cdf1c19e · 2025-10-13T21:18:40.000+03:00
fix(status-file): prevent deadlock on Windows by commenting out non-async-safe code
diff --git a/src/daemon/status-file.c b/src/daemon/status-file.c
@@ -1495,6 +1495,11 @@ bool daemon_status_file_deadly_signal_received(EXIT_REASON reason, SIGNAL_CODE c
     }
 
 #ifdef HAVE_LIBBACKTRACE
+#if defined(OS_WINDOWS)
+    // THE FOLLOWING CODE IS NOT ASYNC-SIGNAL-SAFE on MSYS2 due to internal locking in the runtime.
+    // This can cause a deadlock when a signal is received while the lock is held.
+    // The code is commented out to prevent the deadlock, at the cost of not saving the status file on a crash.
+#else
     bool safe_to_get_stack_trace = reason != EXIT_REASON_SIGABRT || stacktrace_capture_is_async_signal_safe();
     bool get_stack_trace = stacktrace_available() && safe_to_get_stack_trace && stack_trace_is_empty(&session_status);
 
@@ -1509,7 +1514,8 @@ bool daemon_status_file_deadly_signal_received(EXIT_REASON reason, SIGNAL_CODE c
 
         daemon_status_file_save(static_save_buffer, &session_status, false);
     }
-#endif
+#endif // defined(OS_WINDOWS)
+#endif // HAVE_LIBBACKTRACE
 
     return duplicate;
 }

Original file line number	Diff line number	Diff line change
`@@ -1495,6 +1495,11 @@ bool daemon_status_file_deadly_signal_received(EXIT_REASON reason, SIGNAL_CODE c`
`1495`	`1495`	`}`
`1496`	`1496`
`1497`	`1497`	`#ifdef HAVE_LIBBACKTRACE`
	`1498`	`+#if defined(OS_WINDOWS)`
	`1499`	`+ // THE FOLLOWING CODE IS NOT ASYNC-SIGNAL-SAFE on MSYS2 due to internal locking in the runtime.`
	`1500`	`+ // This can cause a deadlock when a signal is received while the lock is held.`
	`1501`	`+ // The code is commented out to prevent the deadlock, at the cost of not saving the status file on a crash.`
	`1502`	`+#else`
`1498`	`1503`	`bool safe_to_get_stack_trace = reason != EXIT_REASON_SIGABRT \|\| stacktrace_capture_is_async_signal_safe();`
`1499`	`1504`	`bool get_stack_trace = stacktrace_available() && safe_to_get_stack_trace && stack_trace_is_empty(&session_status);`
`1500`	`1505`
`@@ -1509,7 +1514,8 @@ bool daemon_status_file_deadly_signal_received(EXIT_REASON reason, SIGNAL_CODE c`
`1509`	`1514`
`1510`	`1515`	`daemon_status_file_save(static_save_buffer, &session_status, false);`
`1511`	`1516`	`}`
`1512`		`-#endif`
	`1517`	`+#endif // defined(OS_WINDOWS)`
	`1518`	`+#endif // HAVE_LIBBACKTRACE`
`1513`	`1519`
`1514`	`1520`	`return duplicate;`
`1515`	`1521`	`}`