test: serialize legacy model environment overrides#1656
Merged
Conversation
Aaronontheweb
enabled auto-merge (squash)
July 15, 2026 14:51
Aaronontheweb
force-pushed
the
fix/serialize-legacy-model-environment-tests
branch
from
July 15, 2026 14:57
d659f9b to
8bff6d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failure
PR #1653 exposed an unrelated Windows-only race:
ModelCommandTests.Set_ClearContextWindow_RemovesStoredClampfailed becauseNETCLAW_Models__Main__ModelIdwas temporarily set by a concurrently running doctor test. The model command correctly refuses migration under that legacy override.Fix
Put the two test classes that mutate
NETCLAW_Models__Main__ModelIdin an xUnit collection withDisableParallelization = true. This serializes the process-wide environment mutation against the entire assembly while preserving parallel execution for tests that do not mutate it.Validation
Netclaw.Cli.Tests: 1,252 passeddotnet slopwatch analyzepwsh ./scripts/Add-FileHeaders.ps1 -Verify